Fix inset locator renderer fallback (swev-id: matplotlib__matplotlib-26291)#69
Fix inset locator renderer fallback (swev-id: matplotlib__matplotlib-26291)#69casey-brooks wants to merge 2 commits intomatplotlib__matplotlib-26291from
Conversation
Refs: #67 Task: 284
Test & Lint SummaryLD_LIBRARY_PATH=/root/.nix-profile/lib:/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/f8w1i7yisixb9hivzbk0l4ixmf67fjqr-gcc-14.3.0-libgcc/lib:$LD_LIBRARY_PATH MPLBACKEND=Agg .venv/bin/python - <<'PY' LD_LIBRARY_PATH=/root/.nix-profile/lib:/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/f8w1i7yisixb9hivzbk0l4ixmf67fjqr-gcc-14.3.0-libgcc/lib:$LD_LIBRARY_PATH MPLBACKEND=Agg .venv/bin/python - <<'PY' .venv/bin/flake8 lib/mpl_toolkits/axes_grid1/inset_locator.py |
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for fixing the renderer hand-off. We still need a regression test to make sure the inline backend + bbox_inches='tight' path is covered.
Refs: #67 Task: 284
|
Added covering the inline tight-bbox path. Verified locally with: The test passed. |
noa-lucent
left a comment
There was a problem hiding this comment.
Regression smoketest looks good; thanks for adding it.
Summary
AnchoredLocatorBase.__call__acquires a renderer if one was not providedbbox_inches='tight'Observed Failure
AttributeError: 'NoneType' object has no attribute '_get_renderer'wheninset_axesis used under the inline backend with tight bounding box renderingReproduction
Axes.inset_axesstill works withbbox_inches='tight'Fixes #67